Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates squad tables from the legacy DataTable widget system to the new Table2 widget system, implementing dynamic column visibility to hide empty columns and removing obsolete mobile-specific layouts.
Changes:
- Replaces DataTable-based squad rendering with Table2 widgets
- Implements column visibility analysis to hide columns with no data (e.g., team icons for loan status, position/role, dates)
- Removes old RosterCard.scss and mobile-specific markup
- Updates SquadRow API to accept columnVisibility parameter and removes cellTitle parameter from date() method
- Wraps squad output in ColumnVisibility context for propagation to child components
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| stylesheets/commons/RosterCard.scss | Deleted entire legacy squad table stylesheet (180 lines including mobile responsive styles) |
| stylesheets/Main.scss | Removed import of deleted RosterCard.scss |
| lua/wikis/commons/Widget/Table2/Cell.lua | Added defaultProps with nowrap=true and added buildCellAttributes call for align/nowrap/shrink support |
| lua/wikis/commons/Widget/Table2/CellHeader.lua | Added buildCellAttributes call for header cells to support align/nowrap/shrink properties |
| lua/wikis/commons/Widget/Squad/Core.lua | Migrated from DataTable to Table2 widgets, added column visibility checking in header generation |
| lua/wikis/commons/Widget/Contexts/Squad.lua | Added ColumnVisibility context for propagating visibility state |
| lua/wikis/commons/Squad/Utils.lua | Added analyzeColumnVisibility function, updated defaultRunManual/Auto to compute and pass columnVisibility, updated function signatures to include columnVisibility parameter |
| lua/wikis/commons/Squad/Row.lua | Migrated from Widget.Td/Tr to Table2 Cell/Row, added columnVisibility support, removed mobile-specific markup, removed cellTitle parameter from date() method, simplified content rendering |
| lua/wikis/stormgate/Squad/Custom.lua | Updated _playerRow signature to accept columnVisibility, removed cellTitle arguments from date() calls |
| lua/wikis/starcraft2/Squad/Custom.lua | Updated _playerRow signature to accept columnVisibility, removed cellTitle arguments from date() calls |
| lua/wikis/starcraft/Squad/Custom.lua | Updated inline function in defaultRunManual to accept columnVisibility, removed cellTitle arguments from date() calls |
| lua/wikis/smash/Squad/Custom.lua | Added columnVisibility computation and wrapping with ColumnVisibility context, removed cellTitle arguments from date() calls |
| lua/wikis/overwatch/Squad/Custom.lua | Added columnVisibility computation and passing to _playerRow, added ColumnVisibility context wrapper, removed cellTitle arguments from date() calls |
| lua/wikis/dota2/Squad/Custom.lua | Updated _playerRow signature to accept columnVisibility, removed cellTitle arguments from date() calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
is it intended to remove the mobile display? before: after: |
Collaborator
yes |
Rathoz
changed the title
Rathoz
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
How did you test this change?
|dev=urton squad tables on team pages. Tested on Dota2, Valorant, CSBefore (manual):
After(manual):
Before(auto):
After(auto):
